-
Notifications
You must be signed in to change notification settings - Fork 383
freeze requirements in Dockerfile #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
minrk
wants to merge
3
commits into
jupyterhub:main
Choose a base branch
from
minrk:freeze-docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # freeze current requirements, used in Dockerfile | ||
| . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # | ||
| # This file is autogenerated by pip-compile with Python 3.12 | ||
| # by the following command: | ||
| # | ||
| # ./scripts/refreeze | ||
| # | ||
| certifi==2026.2.25 | ||
| # via requests | ||
| charset-normalizer==3.4.5 | ||
| # via | ||
| # jupyter-repo2docker | ||
| # requests | ||
| docker==7.1.0 | ||
| # via jupyter-repo2docker | ||
| entrypoints==0.4 | ||
| # via jupyter-repo2docker | ||
| escapism==1.1.0 | ||
| # via jupyter-repo2docker | ||
| idna==3.11 | ||
| # via requests | ||
| iso8601==2.1.0 | ||
| # via jupyter-repo2docker | ||
| jinja2==3.1.6 | ||
| # via jupyter-repo2docker | ||
| jupyter-repo2docker @ file:///tmp/src | ||
| # via -r requirements.in | ||
| markupsafe==3.0.3 | ||
| # via jinja2 | ||
| packaging==26.0 | ||
| # via jupyter-repo2docker | ||
| python-json-logger==4.0.0 | ||
| # via jupyter-repo2docker | ||
| requests==2.32.5 | ||
| # via | ||
| # docker | ||
| # jupyter-repo2docker | ||
| ruamel-yaml==0.19.1 | ||
| # via jupyter-repo2docker | ||
| semver==3.0.4 | ||
| # via jupyter-repo2docker | ||
| toml==0.10.2 | ||
| # via jupyter-repo2docker | ||
| traitlets==5.14.3 | ||
| # via jupyter-repo2docker | ||
| urllib3==2.6.3 | ||
| # via | ||
| # docker | ||
| # requests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| #!/usr/bin/env python3 | ||
| """ | ||
| Run pip-compile in docker to generate requirements.txt | ||
|
|
||
| Should only need running when requirements change in pyproject.toml, which is uncommon. | ||
| Dependabot should handle updating requirements.txt most of the time. | ||
| """ | ||
|
|
||
| from pathlib import Path | ||
| from subprocess import run | ||
|
|
||
| repo = Path(__file__).parents[1].resolve() | ||
|
|
||
|
|
||
| def get_alpine_version(): | ||
| """ | ||
| Get the alpine version from our dockerfile | ||
|
|
||
| make sure we're running with the same version as the docker image. | ||
| """ | ||
| dockerfile = repo / "Dockerfile" | ||
| with dockerfile.open() as f: | ||
| for line in f: | ||
| if "ALPINE_VERSION" in line: | ||
| return line.partition("=")[2].strip() | ||
| raise ValueError(f"Couldn't find ALPINE_VERSION= in {dockerfile}") | ||
|
|
||
|
|
||
| def refreeze(): | ||
| """ | ||
| Run pip-compile in docker to generate requirements.txt | ||
| """ | ||
|
|
||
| alpine_version = get_alpine_version() | ||
| run( | ||
| [ | ||
| "docker", | ||
| "run", | ||
| "--rm", | ||
| f"-v{repo}:/tmp/src", | ||
| "-w/tmp/src", | ||
| "-eCUSTOM_COMPILE_COMMAND=./scripts/refreeze", | ||
| f"alpine:{alpine_version}", | ||
| "sh", | ||
| "-c", | ||
| """ | ||
| apk add py3-pip git | ||
| python3 -m venv /tmp/venv | ||
| source /tmp/venv/bin/activate | ||
| pip install pip-tools | ||
| pip-compile | ||
| """, | ||
| ] | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| refreeze() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.