fix: include tool fields in CompletionResponse.to_dict()#51
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix: include tool fields in CompletionResponse.to_dict()#51cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
CompletionResponse.to_dict() only serialized role and content on messages, dropping tool_calls and tool_call_id needed for multi-turn tool workflows. It also omitted tools_used, tool_execution_cost, and tool_execution_history. Use message.model_dump() for full message serialization and append tool metadata when present. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompletionResponse.to_dict()only serializedroleandcontenton messages, which droppedtool_callsandtool_call_idneeded for multi-turn tool workflows. It also omittedtools_used,tool_execution_cost, andtool_execution_history.Changes
message.model_dump()for full message serialization (includestool_calls,tool_call_id,name,function_call)logprobson choices when presenttools_used,tool_execution_cost,tool_execution_history) when settests/test_completion_response.pyTesting
All CI checks pass locally:
ruff check justllms/black --check justllms/mypy justllms/ --ignore-missing-importspytest tests/ -v(97 tests)python -m build+ wheel import verification