fix: validate Message objects in validate_messages#55
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Message instances were previously appended without running the same checks applied to dict inputs, allowing empty user content to slip through when callers passed pre-built Message objects. Convert Message objects via model_dump() and route them through the existing dict validation path. Add tests covering empty content, tool turns, and mixed dict/Message input. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a validation inconsistency where pre-built
Messageobjects bypassed all checks invalidate_messages(), while equivalent dict inputs were fully validated.Branch:
darshan/validate-message-objectsProblem
When callers passed
Messageinstances directly, they were appended without validation. This allowed invalid messages (e.g. empty user content) to reach provider APIs, while the same content as a dict would raiseValidationError.Solution
Convert
Messageobjects to dicts viamodel_dump()and route them through the existing dict validation path, ensuring consistent behavior regardless of input type.Tests
Added
tests/test_validators.pycovering:MessageobjectsMessageinputCI
All checks pass locally:
ruff check justllms/black --check justllms/mypy justllms/ --ignore-missing-importspytest tests/ -v(102 tests)python3 -m build