Fix basal and user mode durations being truncated in auto-update mode - #139
Open
egyptianbman wants to merge 1 commit into
Open
Fix basal and user mode durations being truncated in auto-update mode#139egyptianbman wants to merge 1 commit into
egyptianbman wants to merge 1 commit into
Conversation
Basal and user mode durations were being reported as zero when polling frequently because the final event in a sync batch was being capped at its own timestamp. This rendered active therapy and device modes invisible in Nightscout until subsequent data arrived. Extending active event durations to the actual synchronization time and enforcing a minimum visibility threshold ensures that ongoing pump states are accurately represented and visible in the UI between polling cycles. Using total seconds and rounding improves data robustness and prevents excessive float precision in the uploaded entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basal and user mode durations were being reported as zero when polling frequently because the final event in a sync batch was being capped at its own timestamp. This rendered active therapy and device modes invisible in Nightscout until subsequent data arrived.
Extending active event durations to the actual synchronization time and enforcing a minimum visibility threshold ensures that ongoing pump states are accurately represented and visible in the UI between polling cycles. Using total seconds and rounding improves data robustness and prevents excessive float precision in the uploaded entries.
With 180s --auto-update, before:
after:
