install.sh: Simplify handling for fedora rpm-ostree based distributions#13712
Merged
brandond merged 1 commit intok3s-io:mainfrom Mar 10, 2026
Merged
install.sh: Simplify handling for fedora rpm-ostree based distributions#13712brandond merged 1 commit intok3s-io:mainfrom
brandond merged 1 commit intok3s-io:mainfrom
Conversation
…butions Signed-off-by: Tom Risse <tom@becarusys.de>
brandond
approved these changes
Mar 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13712 +/- ##
==========================================
- Coverage 21.79% 21.77% -0.02%
==========================================
Files 191 191
Lines 15539 15539
==========================================
- Hits 3386 3384 -2
- Misses 11702 11704 +2
Partials 451 451
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manuelbuil
approved these changes
Mar 3, 2026
Member
|
No backports necessary as the install script is served live from main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
While figuring out #13711 I noticed that the handling of fedora rpm-ostree based distributions for k3s-selinux installation was convoluted and seemed inconsistent. After looking at git blame for a while I propose these changes:
VARIANT_IDis redundant. AlsoID_LIKE=coreosis no longer used by fedora coreos, so drop that as well.package_installer=yuminstead of rpm-ostree for the policy hint, as yum will not work on any rpm-ostree based distribution.policy_error=warnfor immutable fedora. This seems to be a relic from before k3s shipped selinux-packages for fedora. If the selinux policy is not found it prints a warning to reboot the machine anyway just a few lines later.Types of Changes
Bugfix: Users should not notice any difference if the installation works. Only if it fails the user gets the fixed policy hint (I do not know if this is worth listing in the release notes).
Verification
Tested successfully on Fedora CoreOS 43.:
Linked Issues
#11170
User-Facing Change
Further Comments
It might make sense to test it in conjunction with PR #13711 to save some time, I am happy to add the commit to it and close this PR if you agree.