-
Notifications
You must be signed in to change notification settings - Fork 100
fix: solve bad block from wrong transactions root hash and blob sidecar existence validation #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blukat29
reviewed
Jan 14, 2026
1c05d90 to
78dfbd9
Compare
a287e4c to
6ab2790
Compare
blukat29
reviewed
Jan 15, 2026
blukat29
reviewed
Jan 15, 2026
ian0371
reviewed
Jan 15, 2026
ian0371
reviewed
Jan 15, 2026
Mdaiki0730
reviewed
Jan 15, 2026
Co-authored-by: murogari <[email protected]>
blukat29
approved these changes
Jan 15, 2026
ian0371
approved these changes
Jan 15, 2026
Mdaiki0730
approved these changes
Jan 15, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issues
CN behavior
Proposer behavior:
wait() -> PostChainEvents().Non-proposer behavior:
wait() -> PostChainEvents(), they only executeInsertChain() -> PostChainEvents().PostChainEvents()need to be called to save sidecars.InsertChain(blockWithSidecar in proposal)upon commit.InsertChain(blockWithoutSidecar in NewBlockMsg)upon receiving new block from other CNs (i.e.,NewBlockMsgwas faster than commit).Changes
This PR contains the following changes:
DeriveTransactionsRootfor safely calculating transactions rootDeriveShaintoDeriveReceiptsRoot:DeriveShais now exclusively for receipts root.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contribute after having read CLA$ make test)Related issues
Further comments