Apply lints #7
Open
Apply lints #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
commented
Sep 8, 2025
Comment on lines
+5
to
+6
| edition = "2021" | ||
| rust-version = "1.63" |
Author
There was a problem hiding this comment.
1.63 was the oldest version I managed to build. This is partially the case as a Cargo.lock was missing before. I added the lock file to simplify these checks against the oldest supported version in the future.
As 1.63 already supports edition 2021, I updated the edition too.
In the future ptr_arg can improve the performance but as the ksc creates .into() calls this is breaking (while its not considered as a breaking change as this widens the usage its breaking with ksc)
it is only used internally and should not be shared as much. While removing this from the trait is technically breaking its not changing the behaviour and isnt used by ksc so it can be changed relatively easily. This allows it to change the arguments reducing the amount of clones.
EdJoPaTo
force-pushed
the
improvements
branch
from
2a9812f to
afb42f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly enables
clippy::pedanticto improve the code quality.My intention here is to not be breaking.
Feel free to ask questions to all the changes or let me remove lints that seem to change too much. I can also apply different lints on different PR when this helps.