Add webMain support #145
Open
Add webMain support #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalinjul
reviewed
Nov 7, 2025
Owner
kalinjul
left a comment
kalinjul
left a comment
There was a problem hiding this comment.
I just had a quick look, didn't have time to test it yet.
Would the sample app work with this?
Comment on lines
+26
to
+45
| val result = webFlow.startWebFlow(request.url, request.url.parameters["redirect_uri"].orEmpty()) | ||
|
|
||
| if (result !is WebAuthenticationFlowResult.Success) { | ||
| // browser closed, no redirect | ||
| Result.failure(OpenIdConnectException.AuthenticationCancelled()) | ||
| return Result.failure(OpenIdConnectException.AuthenticationCancelled()) | ||
| } | ||
|
|
||
| if (result.responseUri == null) { | ||
| return Result.failure(OpenIdConnectException.AuthenticationFailure("No Uri in callback from browser.")) | ||
| } | ||
|
|
||
| return when (val error = getErrorResult<AuthCodeResult>(result.responseUri)) { | ||
| null -> { | ||
| val state = result.responseUri.parameters["state"] | ||
| val code = result.responseUri.parameters["code"] | ||
| Result.success(AuthCodeResult(code, state)) | ||
| } | ||
| else -> { | ||
| return error | ||
| } |
Owner
There was a problem hiding this comment.
Can we keep this in the old-style nested form so it looks just like in iOS/Android/JVM?
I'd like to refactor out this code block anyways, until then i'd like to keep it structurally equal :)
| add(project.projectDir.path) | ||
| add(project.projectDir.path + "/commonMain/") | ||
| add(project.projectDir.path + "/wasmJsMain/") | ||
| add(project.projectDir.path + "/webMain/") |
Owner
There was a problem hiding this comment.
Maybe we need both webMain and wasmJsMain here?
Comment on lines
+28
to
+31
| js(IR) { | ||
| browser() | ||
| binaries.library() | ||
| } |
Owner
There was a problem hiding this comment.
Could we have this in a "configureJsTarget" function just like the others?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for the JS issue.
Description of your changes
WebPopupFlowan expect class to allow for JS and wasmJS implementation.WebMainCodeAuthFlowFactorywhich is a common factory for both JS and wasmJS targets.How has this been tested?
I tested using a Compose Multiplatform, where I used it to open and login via Keycloak Oidc.
Initially, I tested with "empty" implementations of the JS actual classes. I built my app with
composeApp:jsBrowserDevelopmentRunIt failed to do anything as expected. I then implemented the JS actual classes, and it worked.Note that even Compose Web with JS fallback still uses wasm for the Skia UI. I have yet to test it with a pure Kotlin/JS implementation (such as Kotlin React), but I do not have much experience with Kotlin/JS.
Is this a (API-) breaking change?
It breaks an experimental API. Namely,
WasmCodeAuthFlowFactorywas renamed toWebMainCodeAuthFlowFactory.Users would have to update
import org.publicvalue.multiplatform.oidc.appsupport.WasmCodeAuthFlowFactorytoimport org.publicvalue.multiplatform.oidc.appsupport.WebMainCodeAuthFlowFactory