-
Notifications
You must be signed in to change notification settings - Fork 36
Add web main support #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add web main support #149
Conversation
This reverts commit 476a3dc.
|
Marked this as ready for review. Let me know if it needs any adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a yarn.lock because it's just a sample app, could you remove it?
sample-app/kotlin-js-store/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a yarn.lock because it's just a sample app, could you remove it?
Yes, playground is currently broken and i will add the sample app to the main project soon so it's more obvious it is part of the project. Thanks for keeping up with my latest changes on main! |
|
Alrighty I deleted the yarn locks. The thing is, that adding a js sample app could be as simple as adding a JS fallback mode to the sample wasmJs app (other reference). It would feel a bit superfluous though, ideally a dedicated JS sample app could be added later on. |
Checklist for your PR:
Description of your changes
The KMP wizard now ships with a webMain directory by default instead of wasmJsMain. WebMain is preferred for green field projects as it supports both wasmJs and js targets.
Changelog:
build-logic/convention/src/main/kotlin/org/publicvalue/convention/config/Multiplatform.ktsample-app/settings/src/webMain/kotlin/org/publicvalue/multiplatform/oidc/settings/WebMainSettingsStore.ktas file statedArgument type mismatch: actual type is org.w3c.dom.Storage, but com.russhwolf.settings.Storage was expected.upon switching to webMain type. This defaults to local storage.How has this been tested?
./gradlew -p sample-app jsBrowserDevelopmentRun./gradlew publishToMavenLocal -Pversion=0.16.2From my understanding, we need to test with the sample app and not the playground app, right? I've not been able to compile the playground on the parent's main branch.
Is this a (API-) breaking change?
WasmCodeAuthFlowFactoryrenamed toWebCodeAuthFlowFactoryWasmJsSettingsStoretoWebMainSettingsStore