-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(mobile): Add share and collaborative list menus to mobile #2282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit adds support for share list and collaborative list functionality in the mobile app, bringing feature parity with the web app. Changes: - Updated ListActionsMenu to include "Share" and "Manage Collaborators" options - Created ShareListModal component with: - Public list toggle and shareable URL with copy functionality - RSS feed toggle with token generation and copy functionality - Created ManageCollaboratorsModal component with: - Add collaborators with role selection (viewer/editor) - View current collaborators and owner - Update collaborator roles (owner only) - Remove collaborators (owner only) - Revoke pending invitations (owner only) - Read-only mode for non-owners to view collaborators Both modals follow the existing mobile app patterns using React Native's Modal, Switch components, MenuView for selections, and expo-clipboard for copy functionality. The implementation mirrors the web app features while adapting to the mobile UI/UX patterns.
Changed from React Native native Modal components to expo-router screen modals for better navigation integration and native presentation. Changes: - Created new screen files: - apps/mobile/app/dashboard/lists/[slug]/share.tsx - apps/mobile/app/dashboard/lists/[slug]/manage_collaborators.tsx - Updated dashboard layout to register modal screens with presentation: "modal" - Updated ListActionsMenu to use router.push() instead of modal state - Removed old modal components from apps/mobile/components/lists/ Benefits: - Better integration with native navigation stack - Consistent with existing modal patterns in the app (e.g., manage_tags, manage_lists) - Proper back navigation and deep linking support - Native modal presentation animations
WalkthroughThis PR introduces sharing and collaborators management functionality to the mobile dashboard. It adds two new modal screens (Share List and Manage Collaborators), integrates corresponding menu actions into the list actions menu, and implements data fetching, mutations, and UI components for both features with proper error handling and user feedback. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (4)**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx,json,css,md}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/mobile/**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧬 Code graph analysis (1)apps/mobile/app/dashboard/lists/[slug]/share.tsx (6)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.