-
Notifications
You must be signed in to change notification settings - Fork 1.1k
proposal(scheduler): cascading scheduling #7078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive proposal for "cascading cluster affinity scheduling" in Karmada. The core objective is to enhance workload placement strategies in hybrid cloud environments by allowing users to define prioritized cluster groups. This mechanism ensures that workloads first attempt to utilize preferred, often more cost-effective, clusters and then automatically expand to supplementary clusters when primary resources are insufficient, thereby optimizing resource utilization and supporting elastic scaling. The proposal details API changes, necessary scheduler adjustments, and a test plan to integrate this new functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a design proposal for 'Cascading Cluster Affinity Scheduling' in Karmada. The proposal is well-structured and clearly outlines the motivation, goals, and different API design approaches to enable prioritized cluster selection, which is particularly useful for hybrid cloud environments.
My review focuses on the design choices presented in the proposal. I've provided feedback on the three API design approaches, recommending one for its clarity and maintainability. I also pointed out a need for clarification on how the Duplicated replica scheduling strategy would behave in a failover scenario to ensure the design is comprehensive.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7078 +/- ##
==========================================
- Coverage 46.56% 46.55% -0.01%
==========================================
Files 700 700
Lines 48103 48103
==========================================
- Hits 22397 22395 -2
- Misses 24026 24027 +1
- Partials 1680 1681 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zhzhuang-zju <[email protected]>
3ce2d88 to
bde7345
Compare
|
Updated the I've implemented a simple demo locally, and it works well. Here is the link: master...zhzhuang-zju:karmada:poc-cascade. Feel free to give it a try if you're interested. |
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Karmada currently supports declaring a set of candidate clusters through
clusterAffinity, or multiple sets of candidate clusters throughClusterAffinities(which combines multipleclusterAffinityterms in a specific order). However, in either approach, eachclusterAffinityrepresents an independent, mutually exclusive cluster set during a single scheduling process—the scheduler ultimately selects only one cluster group defined by oneclusterAffinityor its subset.This model has limitations in hybrid cloud scenarios (such as coexistence of local data centers and public clouds). In practical use, local clusters typically serve as the preferred resource pool, while public cloud clusters act as extensions or backup resources. The two are not completely independent and mutually exclusive relationships, but should be automatically used supplementarily based on priority when local resources are insufficient.
To address this, this proposal introduces cascading cluster affinity scheduling to describe priority relationships between cluster groups. This mechanism will enable Karmada to better support workload scheduling in hybrid cloud environments and improve the deployment practicality of online applications in terms of elasticity.
Which issue(s) this PR fixes:
Parts of #7014
Special notes for your reviewer:
Does this PR introduce a user-facing change?: