Add last-applied-configuration annotation

[FAUST-BENCHOU]

What type of PR is this?

What this PR does / why we need it:

Need of "TODO: add last-applied-configuration annotation"

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ikaven1024 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/karmadactl/interpret/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @FAUST-BENCHOU, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a long-standing TODO by implementing the last-applied-configuration annotation for customization objects within karmadactl. This annotation is vital for maintaining the desired state of resources, enabling clients to track the previously applied configuration and perform accurate three-way merges during updates, ensuring consistent and predictable resource management.

Highlights

• Last-Applied-Configuration Annotation: Implemented the logic to add the last-applied-configuration annotation to customization objects. This involves serializing a copy of the object (without the annotation itself to prevent recursion) and storing the resulting JSON string as the annotation value.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the last-applied-configuration annotation to the ResourceInterpreterCustomization object during an edit operation. This is a standard practice in Kubernetes to track changes. The implementation correctly handles potential recursion by removing the annotation from a copy of the object before serializing it. I've suggested a small refinement to make the code more concise and robust by handling the case where the annotation map becomes empty.

[gemini-code-assist]

The logic to prepare the object for the last-applied-configuration annotation can be made more robust and concise. The SetAnnotations call on line 180 is redundant as GetAnnotations returns a reference to the map which is modified in-place. Additionally, if the annotations map becomes empty after removing the last-applied-configuration key, it should be set to nil to avoid serializing an empty map in the annotation's value.

Suggested change

	tempCustomization := editedCustomization.DeepCopy()
	tempAnnotations := tempCustomization.GetAnnotations()
	if tempAnnotations != nil {
	delete(tempAnnotations, corev1.LastAppliedConfigAnnotation)
	tempCustomization.SetAnnotations(tempAnnotations)
	}
	tempCustomization := editedCustomization.DeepCopy()
	if tempAnnotations := tempCustomization.GetAnnotations(); tempAnnotations != nil {
	delete(tempAnnotations, corev1.LastAppliedConfigAnnotation)
	if len(tempAnnotations) == 0 {
	tempCustomization.SetAnnotations(nil)
	}
	}

[zhzhuang-zju]

@FAUST-BENCHOU Thank you for your proactive contributions! I've noticed you're working on TODO items, which is great! However, please note that as the project evolves, many of these TODO notes become stale—either because the intended work has already been completed, is no longer relevant, or has been superseded by other changes, as documented in issue #6996.

To ensure your efforts are aligned with the community's current direction and can be accepted, I recommend first discussing in issue #6996 whether the specific TODO item is still applicable and what update strategy should be followed, before proceeding with concrete changes.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.54%. Comparing base (b175217) to head (f18b978).

Files with missing lines	Patch %	Lines
pkg/karmadactl/interpret/edit.go	0.00%	13 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7089      +/-   ##
==========================================
- Coverage   46.55%   46.54%   -0.01%     
==========================================
  Files         700      700              
  Lines       48091    48104      +13     
==========================================
+ Hits        22389    22392       +3     
- Misses      24020    24030      +10     
  Partials     1682     1682              

Flag	Coverage Δ
unittests	46.54% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[FAUST-BENCHOU]

@FAUST-BENCHOU Thank you for your proactive contributions! I've noticed you're working on TODO items, which is great! However, please note that as the project evolves, many of these TODO notes become stale—either because the intended work has already been completed, is no longer relevant, or has been superseded by other changes, as documented in issue #6996.

To ensure your efforts are aligned with the community's current direction and can be accepted, I recommend first discussing in issue #6996 whether the specific TODO item is still applicable and what update strategy should be followed, before proceeding with concrete changes

Sure!i noticed that there are about 80 TODO in project which is a huge nubmber.can i record these TODO in #6996 and analysis their necessity?

[zhzhuang-zju]

Sure!i noticed that there are about 80 TODO in project which is a huge nubmber.can i record these TODO in #6996 and analysis their necessity?

Absolutely, that's exactly what I'd like to do as well. However, I suggest proceeding in small batches—analyzing just one or two at a time.

[FAUST-BENCHOU]

Absolutely, that's exactly what I'd like to do as well. However, I suggest proceeding in small batches—analyzing just one or two at a time.

Got that,I won't bring over some of the todo lists from upstream Kubernetes; I'll start with the essentials.Thx for your advice🙃

[zhzhuang-zju]

You mentioned bringing over TODO lists from upstream Kubernetes—was the TODO item addressed in this PR also imported from upstream Kubernetes?

I've mentioned you in #6996 — we can analyze the approach to address this TODO item.

[FAUST-BENCHOU]

You mentioned bringing over TODO lists from upstream Kubernetes—was the TODO item addressed in this PR also imported from upstream Kubernetes?

No this one in pkg/karmadactl/interpret/edit.go was not.
i mean like
https://github.com/karmada-io/karmada/blob/master/pkg/util/lifted/lua/oslib_safe.go#L113 or
https://github.com/karmada-io/karmada/blob/master/pkg/util/lifted/validatingmci.go#L177