Skip to content

Conversation

@mszacillo
Copy link
Member

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Introduce WorkloadAffinity to the PropagationPolicy API to support anti-affinity and affinity workload scheduling.

Which issue(s) this PR fixes:
Part of #7064

Does this PR introduce a user-facing change?:

`API Change`: Introduced  `WorkloadAffinity` to PropagationPolicy API to support affinity and anti-affinity workload scheduling

@mszacillo mszacillo changed the title Introduce WorkloadAffinity to PropagationPolicy API [API Change] Introduce WorkloadAffinity to PropagationPolicy API Jan 25, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @mszacillo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the PropagationPolicy API by integrating WorkloadAffinity capabilities. This new feature allows users to define sophisticated scheduling rules, ensuring workloads are either co-located (affinity) or separated (anti-affinity) based on specified label keys across different clusters. This provides greater control over workload distribution and resource utilization, improving both performance and resilience.

Highlights

  • API Enhancement: Introduced the WorkloadAffinity field to the PropagationPolicy API, enabling advanced inter-workload affinity and anti-affinity scheduling.
  • Scheduling Control: The new WorkloadAffinity feature allows users to define rules for co-locating or separating workloads based on a groupByLabelKey, providing fine-grained control over workload distribution across clusters.
  • New API Types: Defined new API types: WorkloadAffinity, WorkloadAffinityTerm, and WorkloadAntiAffinityTerm to structure the affinity and anti-affinity rules.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces WorkloadAffinity to the PropagationPolicy API, enabling inter-workload affinity and anti-affinity scheduling. The changes include updates to the API types, CRD definitions, and OpenAPI specification. The implementation is well-documented. My main feedback is to refactor the new API types to reduce code duplication, which will improve long-term maintainability.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.54%. Comparing base (2dac564) to head (ffb2c8a).
⚠️ Report is 73 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7131      +/-   ##
==========================================
- Coverage   46.55%   46.54%   -0.01%     
==========================================
  Files         700      700              
  Lines       48084    48134      +50     
==========================================
+ Hits        22384    22405      +21     
- Misses      24016    24044      +28     
- Partials     1684     1685       +1     
Flag Coverage Δ
unittests 46.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@karmada-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2026
@karmada-bot karmada-bot merged commit 501c50e into karmada-io:master Jan 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants