This repository was archived by the owner on Jun 30, 2018. It is now read-only.
Instance eval with delegation proof of concept.#904
Open
rafael wants to merge 1 commit intokarmi:masterfrom
Open
Instance eval with delegation proof of concept.#904rafael wants to merge 1 commit intokarmi:masterfrom
rafael wants to merge 1 commit intokarmi:masterfrom
Conversation
Owner
|
Hi, there's been a discussion about this quite some time ago e.g. here: https://gist.github.com/ddemaree/1408149 You're take is interesting, since it has a minimal footprint, and it's quite understandable. However, since Tire was retired, I don't think adding features to it makes real sense? (I'm working on a ActiveRecord/Rails/etc integration for the new gem) |
Author
|
Yeah, I thought that about that too. Thanks for the answer! Is it the new gem for Rails live already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been using tire and I've been facing the following issue. Sometimes, I would like to use some helper methods within the search blocks, but I always get an undefined method exception. In the current state, the only work around that I found for that so far is to write the search methods like this:
I notice that this has to do with the use of instance eval inside the DSL. I found this interesting article where they explained a workaround for that:
http://www.dan-manges.com/blog/ruby-dsls-instance-eval-with-delegation
I started a proof of concept to see if it works with tire. It seems to be working.
Is there a reason why you guys didn't allow this? I could implement this in all the other places, but I wanted to have your feedback, I don't know if I'm missing something here and there is a reason to not do this.
Cheers!