gptel-openai: Validate MIME types for media files#1089
Open
jwiegley wants to merge 1 commit intokarthink:masterfrom
Open
gptel-openai: Validate MIME types for media files#1089jwiegley wants to merge 1 commit intokarthink:masterfrom
jwiegley wants to merge 1 commit intokarthink:masterfrom
Conversation
OpenAI's Vision API only supports image formats (JPEG, PNG, GIF, WebP) and does not support PDFs or other document types. Previously, gptel would send any media file as an image_url, causing API errors when PDFs were included. This change adds MIME type validation in gptel--openai-parse-multipart to reject unsupported formats with a clear error message, guiding users to use native Anthropic or Gemini backends for PDF support. Fixes karthink#929 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@karthink I don't use OpenAI through OpenRouter, so I'm not confident of these changes yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #929
OpenAI's Vision API only supports image formats (JPEG, PNG, GIF, WebP) and does not support PDFs or other document types. This PR adds MIME type validation to prevent sending unsupported formats through the OpenAI backend.
Changes
gptel--openai-parse-multipartfunctionIssue Details
When users configured models with PDF support and sent PDFs through OpenRouter's OpenAI-compatible API, the backend would send PDFs as
image_urltypes, causing Azure/OpenAI to reject the request with:Solution
The fix validates MIME types before constructing the API request and throws a descriptive error:
This gives users clear guidance on how to resolve the issue.
Testing
The implementation has been tested to ensure:
🤖 Generated with Claude Code