Open
Conversation
Owner
|
@kiennq thanks for the PR. Does the host url in the token change all the time, or is it otherwise unpredictable? I'm asking since you're repeatedly setting |
Contributor
Author
|
It's depending on the git hub chat token, which will be refreshed time to time. I think it's not going to change but is there issue with always setting those values? |
Owner
|
It's depending on the git hub chat token, which will be refreshed time to time.
I'm surprised the host can change between token refreshes. Is this really the case? I would have assumed it would be enough to set it once from the token.
I think it's not going to change but is there issue with always setting those values?
The header function is setting the backend host and protocol by side effect -- it just seems confusing and the wrong place to do it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to use the correct host url that's set in the token, ex:
api.enterprise.githubcopilot.com