Add :sync argument to gptel-request for synchronous LLM requests#1264
Open
tninja wants to merge 6 commits intokarthink:masterfrom
Open
Add :sync argument to gptel-request for synchronous LLM requests#1264tninja wants to merge 6 commits intokarthink:masterfrom
tninja wants to merge 6 commits intokarthink:masterfrom
Conversation
* Initial plan * Add gptel-request-sync function for synchronous LLM requests Co-authored-by: tninja <714625+tninja@users.noreply.github.com> * Address code review feedback for gptel-request-sync Co-authored-by: tninja <714625+tninja@users.noreply.github.com> * Improve gptel-request-sync stability: FSM-based completion, disable tools Co-authored-by: tninja <714625+tninja@users.noreply.github.com> * Add :sync argument to gptel-request instead of separate gptel-request-sync Co-authored-by: tninja <714625+tninja@users.noreply.github.com> * Remove gptel-request-timeout parameter, hardcode 30s timeout Co-authored-by: tninja <714625+tninja@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tninja <714625+tninja@users.noreply.github.com>
Owner
|
@tninja I'll take a look. BTW, why did you replace the |
Author
|
@karthink You're right — that change was accidental. I unintentionally normalized a couple of CR ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on another one: #1159
@karthink The feedback (#1159 (comment)) was addressed at this commit: 77ace42, sorry for my slow turn around.
Would you mind help take a look? Let me know if there is any other feedback.
Regards
tninja