Add service to stream custom otel traces to otel-collector #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmanap
reviewed
Nov 12, 2024
|
|
||
|
|
||
| with open(envoy_log_path, "r") as f: | ||
| while True: |
Contributor
There was a problem hiding this comment.
I think best to check if the log file exists to begin with, if not that means tracing was off - then no need to run this for loop.
Contributor
Author
There was a problem hiding this comment.
it must exist - if it doesnt we should fail/crash
I also make sure to create this file in Dockerfile see here -https://github.com/katanemo/arch/pull/262/files#diff-8e3a6a6de1bde2a67bc1791e073f4724332070eac7b751f83122f8929eb87f1fR9
| attributes: vec![], | ||
| }); | ||
|
|
||
| trace_data.add_span(Span { |
Contributor
There was a problem hiding this comment.
I think this should be an even in the total_time span. We shouldn't represent TTFT as a separate span because there is technically no new service work. https://opentelemetry.io/docs/concepts/signals/traces/#span-events
salmanap
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change we can generate custom spans showing total time taken by upstream llm