fix: make mcp filter type explicit in mcp_filter demo#871
Open
octo-patch wants to merge 1 commit intokatanemo:mainfrom
Open
fix: make mcp filter type explicit in mcp_filter demo#871octo-patch wants to merge 1 commit intokatanemo:mainfrom
octo-patch wants to merge 1 commit intokatanemo:mainfrom
Conversation
…#644) Update the mcp_filter demo to explicitly declare `type: mcp` on each filter definition, matching the style of the http_filter demo which uses explicit `type: http`. This makes the configuration more readable and self-documenting instead of relying on the implicit default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #644
Problem
The
mcp_filterdemo relied on commented-out notes to indicate thattype: mcpis the default filter type. This was inconsistent with thehttp_filterdemo which explicitly declarestype: httpon each filter.Solution
Add explicit
type: mcpto each filter definition indemos/filter_chains/mcp_filter/config.yaml, replacing the implicit default with a clear, self-documenting declaration. This mirrors the style of thehttp_filterdemo.Testing
validate_prompt_config