Skip to content

fix: exclude internal providers from routing_preferences model validation #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: exclude internal providers from routing_preferences model validation #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b452b
fix: read request_id and traceparent early in on_http_request_headers
Apr 8, 2026
9f76ca2
fix: exclude internal providers from routing_preferences model valida…
Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/brightstaff/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,13 @@ async fn init_app_state(
// Validate that all models referenced in top-level routing_preferences exist in model_providers.
// The CLI renders model_providers with `name` = "openai/gpt-4o" and `model` = "gpt-4o",
// so we accept a match against either field.
// Internal providers (arch-router, arch-function, etc.) are excluded since they are not
// valid routing targets for user-defined routing_preferences.
if let Some(ref route_prefs) = config.routing_preferences {
let provider_model_names: std::collections::HashSet<&str> = config
.model_providers
.iter()
.filter(|p| p.internal != Some(true))
.flat_map(|p| std::iter::once(p.name.as_str()).chain(p.model.as_deref()))
.collect();
for pref in route_prefs {
Expand Down
7 changes: 4 additions & 3 deletions crates/llm_gateway/src/stream_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,10 @@ impl HttpContext for StreamContext {
return Action::Continue;
}

// Capture request ID and traceparent early so all subsequent log messages include them
self.request_id = self.get_http_request_header(REQUEST_ID_HEADER);
self.traceparent = self.get_http_request_header(TRACE_PARENT_HEADER);

// Capture HTTP method and protocol for tracing
self.http_method = self.get_http_request_header(":method");
self.http_protocol = self.get_http_request_header(":scheme");
Expand Down Expand Up @@ -884,9 +888,6 @@ impl HttpContext for StreamContext {
self.delete_content_length_header();
self.save_ratelimit_header();

self.request_id = self.get_http_request_header(REQUEST_ID_HEADER);
self.traceparent = self.get_http_request_header(TRACE_PARENT_HEADER);

Action::Continue
}

Expand Down