Skip to content
This repository was archived by the owner on Jul 17, 2023. It is now read-only.

Add UI element & logic for only tagging specified tags#70

Open
crossCiv4 wants to merge 2 commits intokawalain:masterfrom
crossCiv4:only-include-tags
Open

Add UI element & logic for only tagging specified tags#70
crossCiv4 wants to merge 2 commits intokawalain:masterfrom
crossCiv4:only-include-tags

Conversation

@crossCiv4
Copy link

@crossCiv4 crossCiv4 commented Mar 27, 2023

Currently, while there is a way to (always) add tags (additional tags) and exclude tags, there is no way to make use of this extension to add only 1 or more specified tags if each tag meets the threshold. This use case is particularly helpful when trying to tag different tags at different confidence thresholds, or when trying to minimize the impact of tagging images with existing tags.

Tested in latest version. Sample test case:

  • Single process for an image with 1girl, 1boy
  • Add 1boy to Exclude tags
  • Add 1girl, 1boy to Only include these tags
  • Interrogate. Tags result should be 1girl

@picobyte
Copy link

picobyte commented Jun 6, 2023

Looks good, but may conflict with my pull request. Also, you could add logic to javascript/tagger.js to enable the click adding to this input field. Currently broken, but should work again after my commit.

@crossCiv4
Copy link
Author

Looks good, but may conflict with my pull request. Also, you could add logic to javascript/tagger.js to enable the click adding to this input field. Currently broken, but should work again after my commit.

There hasn't been any activity from the owner in merging PRs since March, so I don't think any of our PRs will get merged; you'd be better off forking it at this point.

@picobyte
Copy link

I did and it's now the main branch for this extension. Inclusion of this change is no longer needed, I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants