This repository was archived by the owner on Jul 17, 2023. It is now read-only.
Add UI element & logic for only tagging specified tags#70
Open
crossCiv4 wants to merge 2 commits intokawalain:masterfrom
Open
Add UI element & logic for only tagging specified tags#70crossCiv4 wants to merge 2 commits intokawalain:masterfrom
crossCiv4 wants to merge 2 commits intokawalain:masterfrom
Conversation
|
Looks good, but may conflict with my pull request. Also, you could add logic to javascript/tagger.js to enable the click adding to this input field. Currently broken, but should work again after my commit. |
Author
There hasn't been any activity from the owner in merging PRs since March, so I don't think any of our PRs will get merged; you'd be better off forking it at this point. |
|
I did and it's now the main branch for this extension. Inclusion of this change is no longer needed, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, while there is a way to (always) add tags (
additional tags) and exclude tags, there is no way to make use of this extension to add only 1 or more specified tags if each tag meets the threshold. This use case is particularly helpful when trying to tag different tags at different confidence thresholds, or when trying to minimize the impact of tagging images with existing tags.Tested in latest version. Sample test case:
1boytoExclude tags1girl, 1boytoOnly include these tags1girl