-
Notifications
You must be signed in to change notification settings - Fork 317
Fix type hint #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thislight
wants to merge
15
commits into
kayak:master
Choose a base branch
from
thislight:fix-type-hint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix type hint #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I discover a failed test for terms.py: I wonder if the original behaviour in the test is intended. |
- fix criterion_replace_table_with_value tests Field == Table, which is unintended.
- fix mypy errors in queries.py - add Protocol class SQLPart
* Added type checking CI flow * ci/typechecking: Removed parallel limit * ci/typechecking: Limit triggers * ci/typechecking: Set trigger to push * ci/typechecking: fixed CI using python 3.1 instead of 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is intended to revised existing type hint in this project and fix all problems about typing reported by mypy.
Including fixes:
__eq__()and__ne__()accept any object as the argument.builderTODO: