Add portName to Operator and Webhooks for Consistency#664
Open
ramasai1 wants to merge 1 commit intokedacore:mainfrom
Open
Add portName to Operator and Webhooks for Consistency#664ramasai1 wants to merge 1 commit intokedacore:mainfrom
portName to Operator and Webhooks for Consistency#664ramasai1 wants to merge 1 commit intokedacore:mainfrom
Conversation
Signed-off-by: Ramasai Venkatsitarambhaskar Tadepalli <ramasai.tadepalli@mongodb.com>
Author
|
@JorTurFer could I please get a review here? |
zroubalik
reviewed
Aug 7, 2024
Member
zroubalik
left a comment
There was a problem hiding this comment.
We shouldn't introduce breaking changes, can we support both approaches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metricServer prometheus section in the KEDA chart provides a
portNamefield which is the name of the port in both the deployment and the service monitor. This is not the case for the operator and admission webhooks. There's not much consistency in how the port name for the deployment is chosen vs how the service/pod monitor objects use said port.This PR unifies the interface by allowing each component to define a
portNameand makes sure that this is the name of the HTTP port being exposed in the deployment + this is the port being used by the service/service monitor/pod monitor.#647 mentions the same thing but I chose to take a different route.
This may cause a breaking change because of
serviceMonitor.portnot getting respected anymore.Checklist