fix: clean up temporary LOB files after each row during indexing - #639
Open
luis100 wants to merge 1 commit into
Open
fix: clean up temporary LOB files after each row during indexing#639luis100 wants to merge 1 commit into
luis100 wants to merge 1 commit into
Conversation
DbvtkExportModule.handleDataRow() never called cleanResources() on
BinaryCell input stream providers, so temp files created by
TemporaryPathInputStreamProvider (Files.createTempFile("dbptk", "lob"))
were only deleted by JVM shutdown hooks. This let /tmp grow to
hundreds of gigabytes when indexing SIARDs with many embedded LOBs.
Mirrors the cleanup loop already used in dbptk-developer's
SinkModule.handleDataRow().
Fixes #638
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbvtkExportModule.handleDataRow()never calledcleanResources()onBinaryCellinput stream providers after converting/indexing a row.TemporaryPathInputStreamProvider(Files.createTempFile("dbptk", "lob")) for LOBs embedded intable.xmlwere therefore only removed by JVM shutdown hooks, letting/tmpgrow to hundreds of gigabytes while indexing SIARDs with many LOBs.dbptk-developer'sSinkModule.handleDataRow(): iterate the row's cells and callcleanResources()on eachBinaryCellafter it has been converted (its content is already read/copied into the row sent to Solr byToolkitStructure2ViewerStructure.getRow(), so this is safe).PathInputStreamProvider.cleanResources()(used for externally-stored LOBs) is a no-op, so external LOB files are left untouched.Fixes #638
Test plan
mvn compilesucceeds/tmp/dbptk*lobfiles no longer accumulate during indexing (only transient per-row temp files should exist at any time)🤖 Generated with Claude Code