Skip to content

Conversation

@eduardojst10
Copy link
Contributor

@eduardojst10 eduardojst10 commented Dec 23, 2025

  • DIP refactoring

    • merged logic from BrowseDIPActionsToolbar and BrowseDIPFileActionsToolbar into a single class BrowseDIPContentActionsToolbar
    • permission fix of 403 forbidden, permission method constant PERMISSION_METHOD_DELETE_DIP correctly updated 'deleteDIPs' - RODA now uses method name for roda-permission.properties
    • 404 handling with error handling using .handle and completable futures when fetching dipFIleAncestors, preventing ui crash if 404 appears
    • fixed issue where deleting a DIP and choosing not to follow the job would leave the user on a static/empty page. The UI now correctly redirects the user to the parent AIP page upon DIP destruction logic
  • Audit logs

    • updated both DIPFile and Files controllers to inject relatedObjectId and specific parameters into RequestControllerAssistant, referencing parent Dip and AIP respectively
    • added i18n entries and list configs for BrowseDIP_auditLogs
  • Files

    • ungrouped download button, only download action now
  • Documentation

    • removed obsolete copy_gwt_rpc.sh
    • consequently corrected DEV_NOTES.md regarding gwt debugging instructions

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 23, 2025
@eduardojst10 eduardojst10 force-pushed the eteixeira-dev-dipToolbar branch from 3a58e60 to c93818b Compare January 15, 2026 10:47
@hmiguim hmiguim requested a review from 006627 January 15, 2026 11:53
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 15, 2026
@hmiguim hmiguim merged commit a0fb35c into development Jan 15, 2026
4 checks passed
@hmiguim hmiguim deleted the eteixeira-dev-dipToolbar branch January 15, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants