Skip to content

Create worker subdirectory for worker docker image#15

Open
AnShafs wants to merge 3 commits into
keikoproj:masterfrom
AnShafs:issue3
Open

Create worker subdirectory for worker docker image#15
AnShafs wants to merge 3 commits into
keikoproj:masterfrom
AnShafs:issue3

Conversation

@AnShafs

@AnShafs AnShafs commented Oct 9, 2019

Copy link
Copy Markdown

fixed #3

@codecov

codecov Bot commented Oct 9, 2019

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.93%. Comparing base (9b5bf31) to head (b85b20f).
Report is 10 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #15   +/-   ##
======================================
  Coverage    0.93%   0.93%           
======================================
  Files           3       3           
  Lines         215     215           
======================================
  Hits            2       2           
  Misses        213     213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davemasselink

Copy link
Copy Markdown

@AnShafs, I believe that #3 calls for one additional change beyond what you've already made.

The line which indicates "Move Dockerfile.worker and script for the worker image to this directory" is referring to kube-forensics-worker.sh as the script file, I believe.

Can you add that to the worker directory in your branch? Do that and I'll go ahead to approve and merge your changes. Thanks!

@AnShafs

AnShafs commented Oct 25, 2019

Copy link
Copy Markdown
Author

@davemasselink Thank you for pointing this out. I updated my branch.

Comment thread Makefile
docker build . -t ${IMG}
docker build . -t ${WORKERIMG} --file Dockerfile.worker
docker build -f ./controllers/Dockerfile . -t ${IMG}
docker build -f ./worker/Dockerfile.worker . -t ${WORKERIMG}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename this file to ./worker/Dockerfile since now we have it in its own subdirectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create worker subdirectory for worker docker image

3 participants