Create a Brscans extension#16291
Open
SMCodesP wants to merge 9 commits into
Open
Conversation
… icon invalidation
Contributor
|
You have to use the recommended icon generator |
bapeey
reviewed
May 29, 2026
Co-authored-by: I am single and need Girlfriend <tebepc@gmail.com>
bapeey
reviewed
May 31, 2026
Comment on lines
+87
to
+89
| override fun latestUpdatesRequest(page: Int): Request = popularMangaRequest(page) | ||
|
|
||
| override fun latestUpdatesParse(response: Response): MangasPage = popularMangaParse(response) |
Contributor
There was a problem hiding this comment.
Update the methods to throw an UnsupportedOperationException and set supportLatest to false
|
|
||
| // =============================== Search =============================== | ||
|
|
||
| override fun searchMangaRequest(page: Int, query: String, filters: FilterList): Request = GET("$apiUrl/manhwas/search/?query=${query.trim()}", headers) |
Contributor
There was a problem hiding this comment.
Use HttpUrl builder to properly encode the query param
Comment on lines
+114
to
+116
| return dto.toSManga(genreMap).apply { | ||
| initialized = true | ||
| } |
Contributor
There was a problem hiding this comment.
initialized is used to indicate that the details have already been set during the popular/latest/search parsing methods
Suggested change
| return dto.toSManga(genreMap).apply { | |
| initialized = true | |
| } | |
| return dto.toSManga(genreMap) |
|
|
||
| // =========================== Manga Details ============================ | ||
|
|
||
| override fun mangaDetailsRequest(manga: SManga): Request = GET("$apiUrl/manhwas/${manga.url}/", headers) |
Contributor
There was a problem hiding this comment.
Override the getMangaUrl and getChapterUrl methods so that the "Open in WebView" feature works correctly
AwkwardPeak7
reviewed
Jun 5, 2026
| @Synchronized | ||
| private fun fetchGenreMap() { | ||
| if (genreMapFetched) return | ||
| try { |
Contributor
There was a problem hiding this comment.
also add a fetchFailed bool so genres are not fetched multiple times on failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a extesion for my scanlator
Closes #10010
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension