Skip to content

Asura Scans: Format comma separated alt titles#17635

Merged
AwkwardPeak7 merged 2 commits into
keiyoushi:mainfrom
prem-k-r:asura-alt-title-regression
Jul 17, 2026
Merged

Asura Scans: Format comma separated alt titles#17635
AwkwardPeak7 merged 2 commits into
keiyoushi:mainfrom
prem-k-r:asura-alt-title-regression

Conversation

@prem-k-r

@prem-k-r prem-k-r commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Regression: reverted from alternativeTitles back to alt_titles (Related #17626 )
1. alternativeTitles is blank for some series, unlike alt_titles — e.g. "A Painter Who Draws Dungeons" or "Got Dropped into a Ghost Story, Still Gotta Work".
2. alternativeTitles uses comma as separator for some series — e.g. "Sword of the Undying", "The Forgotten Field" or "Only I Have an EX-Grade Summon" and many more. Comma can be part of a title, whereas alt_titles uses newline or • only.

Nvm, just noticed switched from REST API to Astro props

Checklist:

  • Updated versionCode value in build.gradle.kts
  • Updated baseVersionCode in build.gradle.kts (if updated multisrc theme code)
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Set the contentWarning configuration in build.gradle.kts appropriately
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by running the extension
  • Have removed web_hi_res_512.png when adding a new extension
  • This PR is AI-assisted, I have reviewed the changes manually and confirmed they are not slop

@prem-k-r
prem-k-r marked this pull request as draft July 16, 2026 05:00
@prem-k-r prem-k-r changed the title Asura Scans: Revert to alt titles Asura Scans: Format comma separated alt titles Jul 16, 2026
@prem-k-r
prem-k-r marked this pull request as ready for review July 16, 2026 23:00
@AwkwardPeak7
AwkwardPeak7 merged commit 3b556af into keiyoushi:main Jul 17, 2026
2 checks passed
@prem-k-r
prem-k-r deleted the asura-alt-title-regression branch July 17, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants