Ariverse: Add deeplink, move to lib 1.6, some improve code#17657
Open
FiorenMas wants to merge 2 commits into
Open
Ariverse: Add deeplink, move to lib 1.6, some improve code#17657FiorenMas wants to merge 2 commits into
FiorenMas wants to merge 2 commits into
Conversation
AwkwardPeak7
requested changes
Jul 17, 2026
Co-Authored-By: AwkwardPeak7 <48650614+AwkwardPeak7@users.noreply.github.com>
| original | ||
| } | ||
| private suspend fun loadAuthToken() { | ||
| if (cachedAuthToken != null) return |
Contributor
There was a problem hiding this comment.
keep a time or bool as well, so we don't call webview again and againt when first time didn't return anything
Comment on lines
+57
to
+60
| val token = runCatching { | ||
| getLocalStorage(baseUrl, "token") | ||
| ?.takeIf { it.isNotBlank() } | ||
| }.getOrNull() |
Contributor
There was a problem hiding this comment.
no need for runCatching. also can it be blank?
| override val supportsFilterFetching get() = true | ||
|
|
||
| override suspend fun fetchFilterData(): JsonElement = client.get("$apiUrl/genres").parseAs<JsonElement>() | ||
| override suspend fun fetchFilterData(): JsonElement = client.get("$apiUrl/genres".toHttpUrl()).parseAs<JsonElement>() |
Contributor
There was a problem hiding this comment.
no need to make httpurl
| manga | ||
| val story = client.get("$apiUrl/stories/$slug".toHttpUrl()) | ||
| .parseAs<StoryDetailResponse>().data | ||
| storyCache[slug] = story |
Contributor
There was a problem hiding this comment.
dont cache in memory. I meant whatever you need for related manga, put in manga.memo
|
|
||
| val updatedChapters = if (fetchChapters) { | ||
| val chapterData = client.get("$apiUrl/stories/$slug/chapters") | ||
| val chapterData = client.get("$apiUrl/stories/$slug/chapters".toHttpUrl()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
versionCodevalue inbuild.gradle.ktsbaseVersionCodeinbuild.gradle.kts(if updated multisrc theme code)contentWarningconfiguration inbuild.gradle.ktsappropriatelyidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extension