-
Notifications
You must be signed in to change notification settings - Fork 13
feat(calendar): introduce EventCreatedTrigger #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): introduce EventCreatedTrigger #285
Conversation
|
Just a small note for the future, if you could use GitHub Keywords when opening PRs to connect it to the proper issue (to automate the entire process a bit more), it would be super helpful to us. You can read a bit more about it here (I've added closing keyword for this particular issue). |
|
When can i expect feedback ? |
|
Hey @Shadterra, thanks for your contribution, we'll review this shortly! |
|
Damn. Hmm I'm not sure i understand the problem why the checks have failed. Would you please enlighten me ? |
|
Checks failed because you need a review approval @Shadterra :) |
src/test/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTriggerTest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Show resolved
Hide resolved
9888ada to
332223d
Compare
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
|
Hello @Shadterra 👋 Did you have time to address the feedback please 🙏 ? |
|
Sorry i will do it tomorrow. I was busy with school these last 2 days and i didn't have time |
|
I fixed all things pointed out in review 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Shadterra 👋, thanks for the contribution!
- Could you please, mark as "Resolved" the discussions where you did the changes.
- I see most of the tests dont actually run maybe you could take some ref from here, on how we test
Triggers? - Also, would be great if you could provide some QA/test screenshots of the plugin using UI.
|
Resolved discussions and i updated tests. |
src/main/java/io/kestra/plugin/googleworkspace/calendar/AbstractCalendarTrigger.java
Outdated
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Show resolved
Hide resolved
src/main/java/io/kestra/plugin/googleworkspace/calendar/EventCreatedTrigger.java
Outdated
Show resolved
Hide resolved
…ctCalendarTrigger.java Co-authored-by: François Delbrayelle <[email protected]>
…vents and use proper structurre like other triggers do
|
Hey @Shadterra, it seems CI is failing could you please have a look at it? Thanks! |
|
Hello @Malaydewangan09 , I don't know what the problem is. And all errors i see on github are: no JSON input found. Could you send me your CI output ? |
|
i just found that have similar errors like here but i dont think i can do anything about it |
|
Hi @Shadterra 👋 |
|
Hi @fdelbrayelle |
Closes #275.
Google Calendar EventCreated Trigger Implementation
Adds a new trigger that monitors Google Calendar for newly created events and executes workflows automatically when new events are detected.
FEATURES
• Monitor single or multiple calendars
• Filter by organizer, keywords, or event status
• Configurable polling intervals (minimum 1 minute)
• Access to complete event data
• Automatic duplicate prevention
• Rich event metadata available in workflow variables
COMPONENTS
• AbstractCalendarTrigger.java - Base class for calendar triggers with flexible scope support
• EventCreatedTrigger.java - Main trigger implementation with inline @Schema documentation
• EventCreatedTriggerTest.java - Test suite with CI compatibility
USAGE EXAMPLES
Simple example - Watch your main calendar:
Advanced example - Multiple calendars with filtering:
SETUP REQUIREMENTS
• Google Cloud project with Calendar API enabled
• Service account with calendar read permissions (scope: https://www.googleapis.com/auth/calendar)
• Service account JSON key stored as Kestra secret
• Share target calendars with the service account's email address
AVAILABLE EVENT DATA
When the trigger fires, your workflow gets access to complete event information including:
• id, summary, description, location, status, htmlLink
• created and updated timestamps
• start/end times with timezone information
• organizer details (email, displayName)
• visibility and eventType
Access this data in workflows using {{ trigger.summary }}, {{ trigger.organizer.email }}, etc.