Skip to content

Conversation

@bishalbera
Copy link
Contributor

image

fixed special character warning in the file created trigger. cc @fdelbrayelle

@kestrabot kestrabot bot added this to Pull Requests Nov 7, 2025
@github-project-automation github-project-automation bot moved this to To review in Pull Requests Nov 7, 2025
@MilosPaunovic MilosPaunovic added kind/external Pull requests raised by community contributors area/plugin Plugin-related issue or feature request labels Nov 7, 2025
@MilosPaunovic MilosPaunovic requested review from a team and fdelbrayelle November 7, 2025 14:10
@fdelbrayelle
Copy link
Contributor

Hi @bishalbera 👋
I think this special char issue was directly fixed recently in the core so maybe we don't need this fix.
cc @loicmathieu

@fdelbrayelle
Copy link
Contributor

@bishalbera Thank you for your work but since the fix has been done directly in the core I'll close the PR 🙏

@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Nov 14, 2025
@bishalbera
Copy link
Contributor Author

@bishalbera Thank you for your work but since the fix has been done directly in the core I'll close the PR 🙏

ok but I had also fixed the examples of the trigger in this pr @fdelbrayelle

@fdelbrayelle fdelbrayelle reopened this Nov 14, 2025
@github-project-automation github-project-automation bot moved this from Done to To review in Pull Requests Nov 14, 2025
@fdelbrayelle
Copy link
Contributor

OK so @bishalbera, could you remove sanitizeFilename and its usage and keep only the examples please?

@bishalbera
Copy link
Contributor Author

OK so @bishalbera, could you remove sanitizeFilename and its usage and keep only the examples please?

done @fdelbrayelle

@fdelbrayelle fdelbrayelle merged commit d21ccc9 into kestra-io:main Nov 14, 2025
1 check failed
@github-project-automation github-project-automation bot moved this from To review to Done in Pull Requests Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin Plugin-related issue or feature request kind/external Pull requests raised by community contributors

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants