Skip to content

Fix event iterator start time clamping#996

Open
preko-p wants to merge 1 commit into
kewisch:mainfrom
preko-p:456-clamp-event-iterator-start
Open

Fix event iterator start time clamping#996
preko-p wants to merge 1 commit into
kewisch:mainfrom
preko-p:456-clamp-event-iterator-start

Conversation

@preko-p

@preko-p preko-p commented Jun 8, 2026

Copy link
Copy Markdown

Summary

  • Clamp Event#iterator(startTime) so an earlier caller-provided start time cannot move recurrence expansion before the event DTSTART.
  • Keep later startTime behavior intact.
  • Repair the existing iterator test typo and add earlier-start regression coverage.

Fixes #456.

Verification

  • PATH=/opt/homebrew/bin:$PATH npm run test-unit -- test/event_test.js (62 passing in no-space verification clone)
  • PATH=/opt/homebrew/bin:$PATH npm run lint
  • PATH=/opt/homebrew/bin:$PATH npm run test (1021 passing, 1 pending, plus 5 acceptance tests in no-space verification clone)
  • git diff --check

Note: the original local checkout path contains a space, which trips the existing test helper's URL.pathname handling before Mocha tests run. I verified the exact same diff in a temporary no-space clone.

AI assistance

Prepared with AI assistance and manually verified before submission.

Signed-off-by: preko06 <istvan.orban@workl.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Iterator will generate events before the event starts

2 participants