Fix event iterator start time clamping#996
Open
preko-p wants to merge 1 commit into
Open
Conversation
Signed-off-by: preko06 <istvan.orban@workl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Event#iterator(startTime)so an earlier caller-provided start time cannot move recurrence expansion before the eventDTSTART.startTimebehavior intact.Fixes #456.
Verification
PATH=/opt/homebrew/bin:$PATH npm run test-unit -- test/event_test.js(62 passing in no-space verification clone)PATH=/opt/homebrew/bin:$PATH npm run lintPATH=/opt/homebrew/bin:$PATH npm run test(1021 passing, 1 pending, plus 5 acceptance tests in no-space verification clone)git diff --checkNote: the original local checkout path contains a space, which trips the existing test helper's
URL.pathnamehandling before Mocha tests run. I verified the exact same diff in a temporary no-space clone.AI assistance
Prepared with AI assistance and manually verified before submission.