Skip to content

Conversation

@cadriel
Copy link
Contributor

@cadriel cadriel commented Nov 17, 2017

When setting autoCleanup === true for Types.File the admin would error, and files would not be correctly removed from the relevant file system. I tried this against the Azure adapter and the built in FS adapter.

This PR fixes those issues, and seems to work for both adapters fine.

No tests were broken during the course of this change.

  image1: { type: Types.File, autoCleanup: true, storage: azureStorage },
  image2: { type: Types.File, autoCleanup: true, storage: fileStorage },

@wmertens @jossmac @JedWatson

@njs50 njs50 force-pushed the feature/fix-delete-fs branch from b7e36f7 to 2a86790 Compare March 15, 2018 18:14
@stennie stennie added the bug label May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants