Skip to content

feat: Add clickable functionality to Picker items and set visibleItem… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kez-lab merged 3 commits into from
Nov 12, 2025
+23 −2
Merged

feat: Add clickable functionality to Picker items and set visibleItem… #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eab8c4d
feat: Add clickable functionality to Picker items and set visibleItem…
kez-lab Nov 12, 2025
8134170
feat: Improve Picker item click handling to prevent unnecessary scrol…
kez-lab Nov 12, 2025
5f0fb4f
feat: Enable clickable functionality for Picker items based on availa…
kez-lab Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions datetimepicker/src/commonMain/kotlin/com/kez/picker/Picker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package com.kez.picker

import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.gestures.snapping.rememberSnapFlingBehavior
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.fillMaxWidth
Expand All @@ -20,10 +22,12 @@ import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.derivedStateOf
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.snapshotFlow
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.drawWithContent
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.graphics.BlendMode
import androidx.compose.ui.graphics.Brush
import androidx.compose.ui.graphics.Color
Expand All @@ -42,6 +46,7 @@ import androidx.compose.ui.unit.lerp
import androidx.compose.ui.unit.sp
import kotlinx.coroutines.flow.distinctUntilChanged
import kotlinx.coroutines.flow.mapNotNull
import kotlinx.coroutines.launch
import kotlin.math.abs

/**
Expand Down Expand Up @@ -93,6 +98,7 @@ fun <T> Picker(
) {
val density = LocalDensity.current
val visibleItemsMiddle = remember { visibleItemsCount / 2 }
val scope = rememberCoroutineScope()

val adjustedItems = if (!isInfinity) {
listOf(null) + items + listOf(null)
Expand Down Expand Up @@ -205,6 +211,22 @@ fun <T> Picker(
modifier = Modifier
.height(itemHeight)
.fillMaxWidth()
.clickable(
enabled = getItem(index) != null,
role = Role.Button,
indication = null,
interactionSource = remember { MutableInteractionSource() },
onClick = {
val currentCenterIndex = listState.firstVisibleItemIndex + visibleItemsMiddle
if (index != currentCenterIndex) {
scope.launch {
val targetIndex = (index - visibleItemsMiddle)
.coerceIn(0, listScrollCount - 1)
listState.animateScrollToItem(targetIndex)
}
}
}
)
.padding(itemPadding),
contentAlignment = Alignment.Center
) {
Expand Down
3 changes: 1 addition & 2 deletions sample/src/commonMain/kotlin/com/kez/picker/sample/ui/screen/TimePickerSampleScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import androidx.navigation.NavController
import androidx.navigation.compose.rememberNavController
import com.kez.picker.rememberPickerState
import com.kez.picker.time.TimePicker
import com.kez.picker.util.TimeFormat
Expand Down Expand Up @@ -170,6 +168,7 @@ internal fun TimePickerSampleScreen(
TimePicker(
hourPickerState = hour24State,
minutePickerState = minuteState,
visibleItemsCount = 5,
timeFormat = TimeFormat.HOUR_24
)
}
Expand Down