Disable clickable behavior for null padding items in Picker#20
Closed
Copilot wants to merge 1 commit intofeature/picker_click_animationfrom
Closed
Disable clickable behavior for null padding items in Picker#20Copilot wants to merge 1 commit intofeature/picker_click_animationfrom
Copilot wants to merge 1 commit intofeature/picker_click_animationfrom
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix clickable functionality in Picker items based on feedback
Disable clickable behavior for null padding items in Picker
Nov 12, 2025
Copilot stopped work on behalf of
kez-lab due to an error
November 12, 2025 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
isInfinity = false, the Picker's adjusted items list includes null padding at start and end. These null items were clickable and would attempt to scroll, which doesn't make sense for padding.Changes
enabled = getItem(index) != nullparameter to theclickablemodifier in Picker.kt.clickable( enabled = getItem(index) != null, // Disable for null padding items role = Role.Button, indication = null, interactionSource = remember { MutableInteractionSource() }, onClick = { ... } )✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.