Skip to content

Fix drag animation #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix drag animation #1210

wants to merge 2 commits into from

Conversation

dostrander
Copy link
Contributor

@dostrander dostrander commented Feb 18, 2021 •
edited
Loading

  • Adds a wait animation on drag
  • Adds inset to drag
    • Sometimes if the scrollview isn't full screen it hit's the edge of the view and won't drag the scrollview. So we inset the dragging start 5% to allow it to start dragging

This adds onto @justinseanmartin's PR from #1170

@dostrander dostrander force-pushed the dostrander/fix-drag-animation branch 5 times, most recently from 88c92ac to 4927720 Compare February 18, 2021 21:32
@justinseanmartin justinseanmartin mentioned this pull request Feb 19, 2021
Closed
@dostrander dostrander force-pushed the dostrander/fix-drag-animation branch 2 times, most recently from 1bcc08a to 604dc2b Compare February 19, 2021 12:28
@dostrander dostrander force-pushed the dostrander/fix-drag-animation branch from 604dc2b to 96dda56 Compare February 19, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinseanmartin justinseanmartin justinseanmartin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dostrander @justinseanmartin