ci: add GitHub workflow to analyze and test sdk#57
ci: add GitHub workflow to analyze and test sdk#57victoreronmosele wants to merge 7 commits intokinde-oss:mainfrom
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds a test mock response for the Flutter AppAuth Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The workflow run can be viewed at https://github.com/victoreronmosele/kinde-flutter-sdk/pull/1/checks. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
.github/workflows/ci.yamlis excluded by!**/*.yaml
📒 Files selected for processing (1)
test/mock_channels.dart(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: kartuli98
Repo: kinde-oss/kinde-flutter-sdk PR: 27
File: example/lib/state/app_state_manager.dart:79-94
Timestamp: 2025-06-20T10:44:49.809Z
Learning: In the Kinde Flutter SDK, version 1.0.4 will change the login() method to return a token when login is successful, rather than returning void. Code in this repository may be written to anticipate this future API change.
📚 Learning: 2025-06-20T10:44:49.809Z
Learnt from: kartuli98
Repo: kinde-oss/kinde-flutter-sdk PR: 27
File: example/lib/state/app_state_manager.dart:79-94
Timestamp: 2025-06-20T10:44:49.809Z
Learning: In the Kinde Flutter SDK, version 1.0.4 will change the login() method to return a token when login is successful, rather than returning void. Code in this repository may be written to anticipate this future API change.
Applied to files:
test/mock_channels.dart
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
test/mock_channels.dart (1)
19-21: Fix aligns mockendSessionreturn shape with expectedEndSessionResponseserialization.
This addresses the earlier feedback to include the nullablestatekey (returning{'state': null}) instead ofnull/missing keys.Also applies to: 72-74
🧹 Nitpick comments (1)
test/mock_channels.dart (1)
19-21: Preferfinal+ explicit type forendSessionResponse(avoid accidental mutation, improve analyzer signal).
Consider typing it asfinal Map<String, Object?> endSessionResponse = {'state': null};.
…nly on the sdk package
4c47a42 to
1fbfebc
Compare
dtoxvanilla1991
left a comment
There was a problem hiding this comment.
Great addition. Left some 💭 s
Explain your changes
This PR adds a GitHub workflow that analyzes and tests the SDK.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.