Skip to content

ci: add GitHub workflow to analyze and test sdk#57

Open
victoreronmosele wants to merge 7 commits intokinde-oss:mainfrom
victoreronmosele:feat/build-and-test-workflow
Open

ci: add GitHub workflow to analyze and test sdk#57
victoreronmosele wants to merge 7 commits intokinde-oss:mainfrom
victoreronmosele:feat/build-and-test-workflow

Conversation

@victoreronmosele
Copy link
Member

@victoreronmosele victoreronmosele commented Dec 12, 2025

Explain your changes

This PR adds a GitHub workflow that analyzes and tests the SDK.

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .github/workflows/ci.yaml is excluded by !**/*.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Adds a test mock response for the Flutter AppAuth endSession method by returning a map {'state': null} instead of null in test/mock_channels.dart.

Changes

Cohort / File(s) Change Summary
Test mock method handling
test/mock_channels.dart
Adds endSessionResponse = {'state': null} and handles the 'endSession' method call to return that map rather than null, altering the observable mock return for endSession in tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title describes adding a GitHub workflow, but the actual changeset only modifies test/mock_channels.dart to add endSession mock handling. Update the title to reflect the actual change: 'test: add mock endSession response to mock_channels.dart' or similar.
Description check ⚠️ Warning The description claims to add a GitHub Actions workflow for SDK analysis and testing, but the changeset only modifies a mock channels file. Update the description to accurately document the mock endSession response addition, or verify the correct files were included in this PR.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@victoreronmosele victoreronmosele changed the title ci: add github workflow to analyze and test sdk ci: add GitHub workflow to analyze and test sdk Dec 12, 2025
@victoreronmosele victoreronmosele marked this pull request as ready for review December 12, 2025 13:57
@victoreronmosele victoreronmosele requested a review from a team as a code owner December 12, 2025 13:57
@victoreronmosele
Copy link
Member Author

The workflow run can be viewed at https://github.com/victoreronmosele/kinde-flutter-sdk/pull/1/checks.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f84c83 and 8541906.

⛔ Files ignored due to path filters (1)
  • .github/workflows/ci.yaml is excluded by !**/*.yaml
📒 Files selected for processing (1)
  • test/mock_channels.dart (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: kartuli98
Repo: kinde-oss/kinde-flutter-sdk PR: 27
File: example/lib/state/app_state_manager.dart:79-94
Timestamp: 2025-06-20T10:44:49.809Z
Learning: In the Kinde Flutter SDK, version 1.0.4 will change the login() method to return a token when login is successful, rather than returning void. Code in this repository may be written to anticipate this future API change.
📚 Learning: 2025-06-20T10:44:49.809Z
Learnt from: kartuli98
Repo: kinde-oss/kinde-flutter-sdk PR: 27
File: example/lib/state/app_state_manager.dart:79-94
Timestamp: 2025-06-20T10:44:49.809Z
Learning: In the Kinde Flutter SDK, version 1.0.4 will change the login() method to return a token when login is successful, rather than returning void. Code in this repository may be written to anticipate this future API change.

Applied to files:

  • test/mock_channels.dart

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
test/mock_channels.dart (1)

19-21: Fix aligns mock endSession return shape with expected EndSessionResponse serialization.
This addresses the earlier feedback to include the nullable state key (returning {'state': null}) instead of null/missing keys.

Also applies to: 72-74

🧹 Nitpick comments (1)
test/mock_channels.dart (1)

19-21: Prefer final + explicit type for endSessionResponse (avoid accidental mutation, improve analyzer signal).
Consider typing it as final Map<String, Object?> endSessionResponse = {'state': null};.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8541906 and 4c47a42.

📒 Files selected for processing (1)
  • test/mock_channels.dart (2 hunks)

@victoreronmosele victoreronmosele force-pushed the feat/build-and-test-workflow branch from 4c47a42 to 1fbfebc Compare January 1, 2026 12:00
@victoreronmosele victoreronmosele marked this pull request as draft January 1, 2026 12:02
@victoreronmosele victoreronmosele marked this pull request as ready for review January 15, 2026 22:10
Copy link

@dtoxvanilla1991 dtoxvanilla1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Left some 💭 s

Copy link

@dtoxvanilla1991 dtoxvanilla1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 🕵🏿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants