Support excludes for functions with type parameters#278
Open
konradreiche wants to merge 2 commits intokisielk:masterfrom
Open
Support excludes for functions with type parameters#278konradreiche wants to merge 2 commits intokisielk:masterfrom
konradreiche wants to merge 2 commits intokisielk:masterfrom
Conversation
Go 1.26 added errors.AsType, which can appear as:
_, ok := errors.AsType[*SomeError](err)
An exclusion file entry for errors.AsType currently does not match this
form, as described in kisielk#274. This change unwraps type parameters and
parenthesized expressions before matching selectors or identifiers for
exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.26 added
errors.AsType, which can appears as:An exclusion file entry for
errors.AsTypecurrently does not match this form, as described in #274. This change unwraps type parameters and parenthesized expressions before matching selectors or identifiers for exclusions.Not sure if exclusions are the preferred long-term fix here, or if
errors.AsTypeshould get more targeted handling. I kept this change narrow, but happy to adjust if there's a better direction 🙂