Use monolithic PUT to upload large layers to Amazon ECR#822
Merged
amisevsk merged 3 commits intokitops-ml:mainfrom Apr 10, 2025
Merged
Use monolithic PUT to upload large layers to Amazon ECR#822amisevsk merged 3 commits intokitops-ml:mainfrom
amisevsk merged 3 commits intokitops-ml:mainfrom
Conversation
gorkem
reviewed
Apr 10, 2025
Amazon ECR registries return HTTP 201 after the first chunk in a multi-part upload, which is unexpected and causes the upload to fail. To avoid this, we can default to using a monolithic PUT. Signed-off-by: Angel Misevski <amisevsk@gmail.com>
Signed-off-by: Angel Misevski <amisevsk@gmail.com>
Since URLs are case-insensitive Signed-off-by: Angel Misevski <amisevsk@gmail.com>
gorkem
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Amazon ECR registries return HTTP 201 after the first chunk in a multi-part upload, which is unexpected and causes the upload to fail. To avoid this, we can default to using a monolithic PUT.
Linked issues
Closes #821