Skip to content

Fix ffmpeg/tests/test_ffmpeg.py: test_pipe() (v1: ignore duplicate frames) #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ffmpeg/tests/test_ffmpeg.py: test_pipe() (v1: ignore duplicate frames) #726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions ffmpeg/tests/test_ffmpeg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,8 +688,8 @@ def test_pipe():
width = 32
height = 32
frame_size = width * height * 3 # 3 bytes for rgb24
frame_count = 10
start_frame = 2
frame_count = 15
start_frame = 3

out = (
ffmpeg.input(
Expand All @@ -716,7 +716,7 @@ def test_pipe():
'-i',
'pipe:0',
'-filter_complex',
'[0]trim=start_frame=2[s0]',
'[0]trim=start_frame={}[s0]'.format(start_frame),
'-map',
'[s0]',
'-f',
Expand All @@ -739,8 +739,19 @@ def test_pipe():
p.stdin.close()

out_data = p.stdout.read()
assert len(out_data) == frame_size * (frame_count - start_frame)
assert out_data == in_data[start_frame * frame_size :]

if start_frame > 0 and len(out_data) < len (in_data):
# ffmpeg 4.x removes trimmed frames
assert len(out_data) == frame_size * (frame_count - start_frame)
assert out_data == in_data[start_frame * frame_size :]
else:
# ffmpeg 5.x duplicates trimmed frames
assert len(out_data) == len(in_data)

for fn in range(0, start_frame):
assert out_data[fn*frame_size] == in_data[start_frame * frame_size]

assert out_data[start_frame * frame_size :] == in_data[start_frame * frame_size :]


def test__probe():
Expand Down