Add bounded concurrent syncing with --max-workers#126
Draft
pierreadorni wants to merge 6 commits intoklieret:mainfrom
Draft
Add bounded concurrent syncing with --max-workers#126pierreadorni wants to merge 6 commits intoklieret:mainfrom
pierreadorni wants to merge 6 commits intoklieret:mainfrom
Conversation
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often have multiple runs at the same time, and found that one long
wandb syncwould be blocking the sync of my other (shorter) runs. I therefore added a concurrency feature to allow for syncing multiple runs at the same time.Summary
wandb syncblocking other runs.--max-workersCLI option (default 1, preserves current behavior).max_workers.Possible improvement
The new concurrency kind of messes up the display when multiple
wandb syncprocesses write to stdout at the same time. This could be solved by capturing the output of thewandb synccommand and printing our own info in a more concurrency-friendly manner, but I chose to not do it as to limit code changes to the minimum.