Add thread safety to all koanf public methods#339
Closed
musicpulpite wants to merge 2 commits intoknadh:masterfrom
Closed
Add thread safety to all koanf public methods#339musicpulpite wants to merge 2 commits intoknadh:masterfrom
musicpulpite wants to merge 2 commits intoknadh:masterfrom
Conversation
Owner
|
Looks like the mutex is causing a deadlock: https://github.com/knadh/koanf/actions/runs/13138967660/job/36969992725?pr=339 |
Author
Good call. I'll dig into this to see where I messed up and will be sure to write some unit tests to prove that it works as intended (will try to use Go's Data Race Detector) before officially opening the PR. |
Owner
|
Closing this in favour of #377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the concerns brought up in Issue #355 and previously in Issue #153.
Since the
koanf.confMapis a shared resource that could be accessed concurrently from different goroutines for reading/updating config values, the solution is to acquire and release async.RWMutexin each public method that accesses theconfMapproperty.A more robust and performant solution would be to refactor the existing
koanf.confMapmap property and all methods in "github.com/knadh/koanf/maps" to use the inherently thread safesync.Mapstructure from the standard library. This approach would remove the overhead of addingRWMutexlocking to any new public methods and provide more granular read locking in the case of many concurrent read operations where the current approach locks the entire map structure for each read. The obvious downside is that it would require a much more intensive refactor.