Add webhook support for confirmation email#2828
Closed
wozniak-slawomir wants to merge 4 commits intoknadh:masterfrom
Closed
Add webhook support for confirmation email#2828wozniak-slawomir wants to merge 4 commits intoknadh:masterfrom
wozniak-slawomir wants to merge 4 commits intoknadh:masterfrom
Conversation
Owner
|
Thanks for the PR @wozniak-slawomir. Coincidentally, there's another PR that seems to have a more generic, universal webhook implementation. I haven't yet had the chance to review it properly though: #2839 |
Author
|
@knadh that's funny it came out like that! Great to know though that someone initiated more generic approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone, hi @knadh. I decided to initiate creating this very basic feature, let me know what you think. I tried to follow contributing guidelines.
Add outgoing webhook for subscription confirmation
This PR adds support for outgoing webhooks that fire when a subscriber
confirms their subscription (both single and double opt-in).
Features
internal/webhookspackage for HTTP webhook deliveryPayload Example
{ "event": "subscription.confirmed", "timestamp": "2024-12-23T00:00:00Z", "data": { "subscriber": { "id": 1, "email": "...", ... }, "lists": [{ "id": 1, "name": "Newsletter" }] } }What needs to be done still?
Please let me know.