This repository was archived by the owner on Jul 1, 2024. It is now read-only.
Implemented: Generic Support for Methods in UnhollowerUtils #89
Open
Sewer56 wants to merge 1 commit intoknah:masterfrom
Open
Implemented: Generic Support for Methods in UnhollowerUtils #89Sewer56 wants to merge 1 commit intoknah:masterfrom
Sewer56 wants to merge 1 commit intoknah:masterfrom
Conversation
AndreLouisIssa
approved these changes
Jun 4, 2022
AndreLouisIssa
left a comment
AndreLouisIssa
left a comment
There was a problem hiding this comment.
Seems to work and this has been a bad problem for a while, merge soon please!
|
Would really like to see this merged 👍 |
|
any updates about this getting merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple patch adds support for fetching Generic methods via the
GetIl2CppMethodInfoPointerFieldForGeneratedMethodAPI insideUnhollowerUtils.Not much to say here, no API changes.
I implemented this in order to allow 3rd party libraries such as HarmonyX (in MelonLoader) to be able to successfully hook generic methods.
[Previously
GetIl2CppMethodInfoPointerFieldForGeneratedMethodwould return null and generic methods were not hookable.