Skip to content

chore: Update Quarkus deps and remove redundant versions override - #4779

Open
dsimansk wants to merge 13 commits into
knative-extensions:mainfrom
dsimansk:pr/update-dependabot
Open

chore: Update Quarkus deps and remove redundant versions override#4779
dsimansk wants to merge 13 commits into
knative-extensions:mainfrom
dsimansk:pr/update-dependabot

Conversation

@dsimansk

@dsimansk dsimansk commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #

Proposed Changes

  • Upgraded to Quarkus 3.33.3.1 LTS platform BOM (io.quarkus.platform:quarkus-bom), maximizing use of Quarkus-managed dependency versions
  • Removed 16+ explicit version properties and managed dependency entries (vertx, jackson, micrometer, netty, slf4j, jose4j, fabric8, mockito, protobuf, guava, junit, kafka) now delegated to Quarkus BOM
  • Eliminated Guava dependency entirely — replaced Guava Cache with Caffeine, Strings.isNullOrEmpty with inline method, Uninterruptibles with inline loop
  • Replaced commons-codec with java.util.HexFormat (JDK 17+) and javax.annotation.Nullable with jakarta.annotation.Nullable
  • Migrated integration tests from Debezium KafkaCluster to StrimziKafkaCluster (io.strimzi:strimzi-test-container:0.116.0), removing debezium-core, kafka_2.13, scala-library, and scala-reflect dependencies
  • Adapted to Kafka 4.x API changes — updated MockProducer constructor calls (added null partitioner arg) and ConsumerRecord construction (removed checksum, added Optional.empty() leaderEpoch)
  • Removed redundant BOM imports (netty-bom, micrometer-bom, jackson-bom) and kept only OTel BOM (before Quarkus for version precedence) + Quarkus platform BOM
  • Cleaned up redundant exclusion blocks and plugin declarations — removed duplicate cloudevents-kafka exclusion in core module, removed redundant maven-compiler-plugin declarations from receiver-loom, dispatcher-loom, and tests modules
  • Fixed stale benchmarks config — removed redundant version tag, updated javac.target from 15 to 21

Release Note

Update to Quarkus 3.33.3.1 LTS  and remove redundant versions override

Docs

/cc @gauron99

@knative-prow

knative-prow Bot commented Aug 5, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2026
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.16%. Comparing base (7d8fe89) to head (9e3dc23).

Files with missing lines Patch % Lines
...eceiver/impl/IngressProducerReconcilableStore.java 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4779      +/-   ##
============================================
+ Coverage     28.91%   36.16%   +7.25%     
- Complexity        0      905     +905     
============================================
  Files           294      403     +109     
  Lines         16209    20051    +3842     
  Branches          0      345     +345     
============================================
+ Hits           4687     7252    +2565     
- Misses        11071    12156    +1085     
- Partials        451      643     +192     
Flag Coverage Δ
java-unittests 66.76% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow Bot added area/test size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 5, 2026
@dsimansk
dsimansk force-pushed the pr/update-dependabot branch from 8c5d8fb to 1128301 Compare August 5, 2026 14:38
@dsimansk

dsimansk commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/test integration-tests

@gauron99

gauron99 commented Aug 5, 2026

Copy link
Copy Markdown

/retest

@dsimansk
dsimansk force-pushed the pr/update-dependabot branch from bdb9614 to df4c86f Compare August 5, 2026 19:19
@dsimansk
dsimansk force-pushed the pr/update-dependabot branch from e20c327 to 5c79583 Compare August 5, 2026 21:57
@dsimansk
dsimansk force-pushed the pr/update-dependabot branch from 7e360ef to f9fd1b7 Compare August 6, 2026 07:43
@dsimansk

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@gauron99

Copy link
Copy Markdown

/retest

@dsimansk
dsimansk force-pushed the pr/update-dependabot branch from 9064df8 to 9e3dc23 Compare August 12, 2026 14:24
@knative-prow

knative-prow Bot commented Aug 12, 2026

Copy link
Copy Markdown

@dsimansk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_main 1128301 link true /test unit-tests

Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gauron99

Copy link
Copy Markdown

/retest

@dsimansk

Copy link
Copy Markdown
Contributor Author

/test unit-tests

@knative-prow

knative-prow Bot commented Aug 13, 2026

Copy link
Copy Markdown

@dsimansk: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build-tests
/test channel-integration-tests-sasl-plain
/test channel-integration-tests-sasl-ssl
/test channel-integration-tests-ssl
/test channel-reconciler-tests-sasl-plain
/test channel-reconciler-tests-sasl-ssl
/test channel-reconciler-tests-ssl
/test integration-tests
/test reconciler-tests
/test reconciler-tests-keda
/test reconciler-tests-namespaced-broker
/test upgrade-tests

Use /test all to run all jobs.

Details

In response to this:

/test unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kwassell-ibm

Copy link
Copy Markdown
Contributor

Very interested in seeing this merged in to give us one spot to resolve the latest stack of CVEs in netty/jackson/vertx. I was going to make a PR to hack things forward in the old format, but I can hold off a bit longer if this is coming to the 1.23.X release branch sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane area/test size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants