Fix publish helm charts by skipping plugin verification#2243
Fix publish helm charts by skipping plugin verification#2243knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
|
|
|
Welcome @lepeli! It looks like this is your first PR to knative/operator 🎉 |
|
Hi @lepeli. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test Thanks a lot for the PR :) Disabling verification is recommended by the error, see e.g. https://github.com/knative/operator/actions/runs/22417568886/job/64907026279#step:4:6 : Run helm plugin install https://github.com/halkeye/helm-repo-html
Error: plugin source does not support verification. Use --verify=false to skip verification
Error: Process completed with exit code 1. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
=======================================
Coverage 63.45% 63.45%
=======================================
Files 49 49
Lines 1899 1899
=======================================
Hits 1205 1205
Misses 600 600
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
houshengbo
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks for fixing it!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, lepeli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
An update of helm 4 added a verification system during plugin installation.
This is something new that has been enabled by default. This broke the helm repo actions since knative v1.19.6.
By adding the flag
--verify=falsewe can disable the verification during the installation (which was the previous behavior).This pull request fixes #2242
Proposed Changes
--verify=falseto thehelm plugin installcommand.Release Note