Skip to content

Fix publish helm charts by skipping plugin verification#2243

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
lepeli:fix-helm-release
Feb 26, 2026
Merged

Fix publish helm charts by skipping plugin verification#2243
knative-prow[bot] merged 1 commit intoknative:mainfrom
lepeli:fix-helm-release

Conversation

@lepeli
Copy link
Contributor

@lepeli lepeli commented Feb 26, 2026

An update of helm 4 added a verification system during plugin installation.

This is something new that has been enabled by default. This broke the helm repo actions since knative v1.19.6.

By adding the flag --verify=false we can disable the verification during the installation (which was the previous behavior).

This pull request fixes #2242

Proposed Changes

  • added --verify=false to the helm plugin install command.

Release Note


@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 26, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: lepeli / name: Yvan (b848062)

@knative-prow
Copy link

knative-prow bot commented Feb 26, 2026

Welcome @lepeli! It looks like this is your first PR to knative/operator 🎉

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 26, 2026

Hi @lepeli. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from houshengbo and matzew February 26, 2026 10:11
@linkvt
Copy link
Contributor

linkvt commented Feb 26, 2026

/ok-to-test
/lgtm

Thanks a lot for the PR :)

Disabling verification is recommended by the error, see e.g. https://github.com/knative/operator/actions/runs/22417568886/job/64907026279#step:4:6 :

Run helm plugin install https://github.com/halkeye/helm-repo-html
Error: plugin source does not support verification. Use --verify=false to skip verification
Error: Process completed with exit code 1.

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 26, 2026
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2026
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.45%. Comparing base (d9965f2) to head (b848062).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2243   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files          49       49           
  Lines        1899     1899           
=======================================
  Hits         1205     1205           
  Misses        600      600           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@houshengbo houshengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for fixing it!

@knative-prow
Copy link

knative-prow bot commented Feb 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, lepeli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2026
@knative-prow knative-prow bot merged commit f9b286d into knative:main Feb 26, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart Helm release action broken since v1.19.6

3 participants