Skip to content

Deal with DSV files missing columns in certain rows #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

Deal with DSV files missing columns in certain rows #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions nemo/src/io/formats/dsv/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ impl<T: BufRead> DsvReader<T> {
.has_headers(self.ignore_headers)
.double_quote(true)
.quoting(self.quoting)
.flexible(true)
.from_reader(self.read)
}

Expand Down Expand Up @@ -107,6 +108,11 @@ impl<T: BufRead> DsvReader<T> {
let mut line_count: u64 = 0;
let mut drop_count: u64 = 0;
for row in dsv_reader.records().flatten() {
if row.len() != expected_file_arity {
drop_count += 1;
continue;
}

for (idx, value) in row.iter().enumerate() {
if idx >= expected_file_arity || skip[idx] {
continue;
Expand Down
8 changes: 8 additions & 0 deletions resources/testcases/data-formats/dsv/missing-column.rls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
@import noHeader :- csv{ resource="sources/missing-columns.csv", ignore_headers=true } .
@import header :- csv{ resource="sources/missing-columns.csv", ignore_headers=false } .

withHeader(?x, ?y) :- header(?x, ?y) .
withoutHeader(?x, ?y) :- noHeader(?x, ?y) .

@export withHeader :- csv{} .
@export withoutHeader :- csv{} .
1 change: 1 addition & 0 deletions resources/testcases/data-formats/dsv/missing-column/withHeader.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
23,42
1 change: 1 addition & 0 deletions resources/testcases/data-formats/dsv/missing-column/withoutHeader.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
23,42
3 changes: 3 additions & 0 deletions resources/testcases/data-formats/dsv/sources/missing-columns.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
column
23, 42
1337