Drop support for unmaintained Symfony versions#465
Merged
bocharsky-bw merged 1 commit intoknpuniversity:mainfrom Nov 5, 2025
Merged
Drop support for unmaintained Symfony versions#465bocharsky-bw merged 1 commit intoknpuniversity:mainfrom
bocharsky-bw merged 1 commit intoknpuniversity:mainfrom
Conversation
dmaicher
force-pushed
the
drop_old_sf
branch
2 times, most recently
from
4cf1a38 to
308f234
Compare
bocharsky-bw
approved these changes
Oct 20, 2025
Member
bocharsky-bw
left a comment
bocharsky-bw
left a comment
There was a problem hiding this comment.
Sf 5.4 is LTS and still supports security fixes, so I would usually keep maintaining it unless it complicates moving forward too much like in this case. So I agree to drop that, we still have 6.4 LTS, should be good enough IMO
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to see how complex adding Symfony 8 support would be and noticed that we require
"symfony/security-guard": "^5.4"which makes it hard to fully require Symfony 8 packages.I'm proposing to drop support for unmaintained Symfony versions first. This will make it easier to add support for Symfony 8.
Note: this means removing the abstract
SocialAuthenticatorclass. It cannot possibly work with Symfony > 5.4. I would not consider this a BC break because people on Symfony 5.4 will not get a new minor update anyway until they have to move to Symfony 6.4+ which means they need to change their authentication config anyway first.WDYT?