Update README for authenticator registration steps#467
Merged
bocharsky-bw merged 2 commits intoknpuniversity:mainfrom Oct 29, 2025
Merged
Update README for authenticator registration steps#467bocharsky-bw merged 2 commits intoknpuniversity:mainfrom
bocharsky-bw merged 2 commits intoknpuniversity:mainfrom
Conversation
Removed instruction to enable authenticator manager in README since the option security.enable_authenticator_manager was deprecated since Symfony 6.2 and throws error in Symfony 7.3. See: scheb/2fa#183
bocharsky-bw
requested changes
Oct 28, 2025
| # ... | ||
| + enable_authenticator_manager: true | ||
|
|
||
| # ... |
Member
There was a problem hiding this comment.
Hm, it could be too aggressive because this bundle still supports legacy Symfony versions ^5.4|^6.0|^7.0 and it may cause problems in legacy versions. How about keeping your changes, but also adding a note below this code block saying something like:
If you have Symfony 6.4 or lower - you will also need to enable the new authenticator manager:
# app/config/packages/security.yaml
security:
# ...
+ enable_authenticator_manager: trueCould you add this change too?
….4 and lower Added important note about enabling the authenticator manager for Symfony 6.4 or lower, including configuration example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed instruction to enable authenticator manager in README since the option security.enable_authenticator_manager was deprecated since Symfony 6.2 and throws error in Symfony 7.3.
See: scheb/2fa#183