configure.ac: fix the msys2 build #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the import library is called ws_32 on the mingw64 platform, search for that in addition to the other winsock libraries. If no library is found, bail out the compilation rather than silently continuing, which causes lots of linker errors later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #22
Apparently the import library is called
ws_32on the mingw64 platform, search for that in addition to the other winsock libraries. If no library is found, bail out the compilation rather than silently continuing, which causes linker errors later.This also fixes issues using
-lin the AC_SEARCH_LIBS call. According to the documentation, you should only put the library name in this macro call, not he compiler's linker flag.This worked for me in mingw64, did not test other targets.